Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1234623002: dart2js: Support natives in the startup emitter. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : reupload #

Patch Set 3 : Reupload (and probably minor fixes). #

Patch Set 4 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -3 lines) Patch
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 2 3 2 chunks +60 lines, -3 lines 0 comments Download
M pkg/js_ast/lib/src/builder.dart View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
5 years, 5 months ago (2015-07-10 18:36:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 5 months ago (2015-07-22 23:29:14 UTC) #4
floitsch
5 years, 4 months ago (2015-08-03 15:45:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
9a633402a76ece2a9422d355a73709fceb2a3e44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698