Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234433006: Upgrade to the new test runner. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/glob@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
D .status View 1 chunk +0 lines, -18 lines 0 comments Download
A .test_config View 1 chunk +5 lines, -0 lines 2 comments Download
M CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +4 lines, -4 lines 0 comments Download
M test/glob_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/match_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/parse_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 5 months ago (2015-07-16 00:04:44 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1234433006/diff/1/.test_config File .test_config (right): https://codereview.chromium.org/1234433006/diff/1/.test_config#newcode3 .test_config:3: "platforms": ["vm"] Why aren't you using the TestOn() annotation?
5 years, 5 months ago (2015-07-16 00:05:49 UTC) #2
nweiz
https://codereview.chromium.org/1234433006/diff/1/.test_config File .test_config (right): https://codereview.chromium.org/1234433006/diff/1/.test_config#newcode3 .test_config:3: "platforms": ["vm"] On 2015/07/16 00:05:49, Bob Nystrom wrote: > ...
5 years, 5 months ago (2015-07-16 00:23:50 UTC) #3
Bob Nystrom
LGTM!
5 years, 5 months ago (2015-07-16 15:38:11 UTC) #4
nweiz
5 years, 5 months ago (2015-07-16 20:11:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
01b7d09c7cb381a200b6700a33de1ef90bf61d02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698