Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234293003: Make analysis_server use ignore patterns from .analysis_options file (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make analysis_server use ignore patterns from .analysis_options file BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/0300e2e9fd6669502643cf3efc1044dbca437f92

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 6 chunks +32 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Brian Wilkerson
LGTM, once the option name is changed https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode196 pkg/analysis_server/lib/src/context_manager.dart:196: YamlList ignore ...
5 years, 5 months ago (2015-07-17 21:03:22 UTC) #2
Cutch
https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode196 pkg/analysis_server/lib/src/context_manager.dart:196: YamlList ignore = analyzer['ignore']; On 2015/07/17 21:03:22, Brian Wilkerson ...
5 years, 5 months ago (2015-07-17 21:09:41 UTC) #3
Cutch
Committed patchset #2 (id:20001) manually as 0300e2e9fd6669502643cf3efc1044dbca437f92 (presubmit successful).
5 years, 5 months ago (2015-07-17 21:10:41 UTC) #4
Brian Wilkerson
https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode522 pkg/analysis_server/lib/src/context_manager.dart:522: rethrow; > The analyzer tells me I need to ...
5 years, 5 months ago (2015-07-17 21:11:54 UTC) #5
Cutch
https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode522 pkg/analysis_server/lib/src/context_manager.dart:522: rethrow; On 2015/07/17 21:11:53, Brian Wilkerson wrote: > > ...
5 years, 5 months ago (2015-07-17 21:13:16 UTC) #6
Brian Wilkerson
5 years, 5 months ago (2015-07-17 21:14:25 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1234293003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:522: rethrow;
> Sorry, I was being dense. I now understand your original question. I've landed
> this already though....

No problem. A follow-up CL will work.

Powered by Google App Engine
This is Rietveld 408576698