Issue 1234273003: - Update _blink library using dart:js instead of native keyword

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234273003: - Update _blink library using dart:js instead of native keyword (Closed)

Created:
5 years, 5 months ago by terry

Modified:
5 years, 5 months ago

Reviewers:
vsm, Alan Knight

CC:
reviews_dartlang.org, ricow1

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Update _blink library using dart:js instead of native keyword - Fixed dart:js event wrapping - Fixed dart2js gen when --gen-interop used - Cleanup and enabled static window() for JS interop - Enabled --gen-interop - Added --gen-interop switch R=vsm@google.com,alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/8ecb64d6b05c457175057f569d26cb7625fd0d09

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8873 lines, -86 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	1	437 chunks	+5816 lines, -75 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1	14 chunks	+160 lines, -3 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1	143 chunks	+1924 lines, -4 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1	28 chunks	+363 lines, -0 lines	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	1	36 chunks	+527 lines, -0 lines	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	1	6 chunks	+79 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/go.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

terry

Committed patchset #2 (id:10001) manually as 8ecb64d6b05c457175057f569d26cb7625fd0d09 (presubmit successful).

5 years, 5 months ago (2015-07-17 14:37:30 UTC) #2

vsm

Is this integration? The Base URL says master. Otherwise, LGTM

5 years, 5 months ago (2015-07-17 14:38:22 UTC) #3

Message was sent while issue was closed.

lgtm