Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1234203003: Add prints to help diagnose flaky async_step_test failure. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add prints to help diagnose flaky async_step_test failure. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/4b5d321682baa754b229743ba0aed9026a37fea8

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/observatory/tests/service/async_step_test.dart View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 5 months ago (2015-07-17 17:47:25 UTC) #2
Cutch
lgtm
5 years, 5 months ago (2015-07-17 17:48:31 UTC) #3
rmacnak
5 years, 5 months ago (2015-07-17 18:08:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4b5d321682baa754b229743ba0aed9026a37fea8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698