Remove deprecated ms arguments for Timer and Future.

Remove deprecated ms arguments for Timer and Future.

Committed: https://code.google.com/p/dart/source/detail?r=19220

[Lasse Reichstein Nielsen, 2013-02-28 11:14:48]

lgtm

https://codereview.chromium.org/12342014/diff/1/pkg/scheduled_test/test/utils...
File pkg/scheduled_test/test/utils.dart (right):

https://codereview.chromium.org/12342014/diff/1/pkg/scheduled_test/test/utils...
pkg/scheduled_test/test/utils.dart:22: Future timeout(Future input, int
milliseconds, onTimeout()) {
Not changing "int milliseconds" to "Duration duration"?

https://codereview.chromium.org/12342014/diff/1/runtime/lib/timer_patch.dart
File runtime/lib/timer_patch.dart (right):

https://codereview.chromium.org/12342014/diff/1/runtime/lib/timer_patch.dart#...
runtime/lib/timer_patch.dart:11: if (milliseconds < 0) milliseconds = 0;
Is that possible? I would have thought Duration disallowed it.
Or is Duration really a TimeDelta, so it can have a direction too?

[floitsch, 2013-02-28 13:24:05]

https://codereview.chromium.org/12342014/diff/1/pkg/scheduled_test/test/utils...
File pkg/scheduled_test/test/utils.dart (right):

https://codereview.chromium.org/12342014/diff/1/pkg/scheduled_test/test/utils...
pkg/scheduled_test/test/utils.dart:22: Future timeout(Future input, int
milliseconds, onTimeout()) {
On 2013/02/28 11:14:48, Lasse Reichstein Nielsen wrote:
> Not changing "int milliseconds" to "Duration duration"?

It's not really in my code. But I would like it to change. I will track down the
owner and ping him/her.

https://codereview.chromium.org/12342014/diff/1/runtime/lib/timer_patch.dart
File runtime/lib/timer_patch.dart (right):

https://codereview.chromium.org/12342014/diff/1/runtime/lib/timer_patch.dart#...
runtime/lib/timer_patch.dart:11: if (milliseconds < 0) milliseconds = 0;
On 2013/02/28 11:14:48, Lasse Reichstein Nielsen wrote:
> Is that possible? I would have thought Duration disallowed it.
> Or is Duration really a TimeDelta, so it can have a direction too?

Duration is a time-delta. We wouldn't even be able to enforce it, since it's a
const-class.

[floitsch, 2013-02-28 13:24:26]

Committed patchset #1 manually as r19220 (presubmit successful).