Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 12342012: Support instruction-level perf event profiling to Dart VM using V8's ll_prof.py. (Closed)

Created:
7 years, 9 months ago by Florian Schneider
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Support instruction-level perf event profiling to Dart VM using V8's ll_prof.py. Usage: 1) perf record -g out/ReleaseIA32/dart --ll-prof example.dart 2) third_party/v8/tools/ll_prof.py --disasm-top=3 This will produce a per-function and a per-instruction profile with disassembly for the top 3 function in the profile. Currently only available on Linux. Committed: https://code.google.com/p/dart/source/detail?r=19044

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
M runtime/vm/os_linux.cc View 1 2 2 chunks +89 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Florian Schneider
7 years, 9 months ago (2013-02-26 13:37:57 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/12342012/diff/2002/runtime/vm/os_linux.cc File runtime/vm/os_linux.cc (right): https://codereview.chromium.org/12342012/diff/2002/runtime/vm/os_linux.cc#newcode47 runtime/vm/os_linux.cc:47: const char* filename = "v8.log.ll"; I like the ...
7 years, 9 months ago (2013-02-26 14:19:25 UTC) #2
Vyacheslav Egorov (Google)
one more comment https://codereview.chromium.org/12342012/diff/2002/runtime/vm/os_linux.cc File runtime/vm/os_linux.cc (right): https://codereview.chromium.org/12342012/diff/2002/runtime/vm/os_linux.cc#newcode102 runtime/vm/os_linux.cc:102: const char* format = "%s%s"; Use ...
7 years, 9 months ago (2013-02-26 14:24:17 UTC) #3
Florian Schneider
Thanks. Fixed x64. Landing... On 2013/02/26 14:24:17, Vyacheslav Egorov (Google) wrote: > one more comment ...
7 years, 9 months ago (2013-02-26 14:31:50 UTC) #4
Florian Schneider
7 years, 9 months ago (2013-02-26 14:38:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19044 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698