Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 12340090: Replaced read() call with FDUtils functions to fix Windows build. (Closed)

Created:
7 years, 9 months ago by Tom Ball
Modified:
7 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Replaced read() call with FDUtils functions to fix Windows build. Committed: https://code.google.com/p/dart/source/detail?r=19095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/bin/vmstats_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Ball
7 years, 9 months ago (2013-02-26 23:21:31 UTC) #1
Ivan Posva
LGTM -ip
7 years, 9 months ago (2013-02-26 23:22:19 UTC) #2
Tom Ball
7 years, 9 months ago (2013-02-26 23:22:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698