Issue 12340085: Progress in generic mixins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12340085: Progress in generic mixins (Closed)

Created:
7 years, 10 months ago by hausner

Modified:
7 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Progress in generic mixins Handle generic mixin applications in class declarations, but not yet in type aliases. Committed: https://code.google.com/p/dart/source/detail?r=19097

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -16 lines)			Patch
M	runtime/vm/class_finalizer.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	5 chunks	+26 lines, -14 lines	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/12340085/diff/4001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/12340085/diff/4001/runtime/vm/parser.cc#newcode3448 runtime/vm/parser.cc:3448: Type& mixin_application_type = Type::Handle(ParseMixins(mixin_super_type)); const? (and break line) ...

7 years, 10 months ago (2013-02-26 22:49:54 UTC) #2

hausner

Thank you. https://codereview.chromium.org/12340085/diff/4001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/12340085/diff/4001/runtime/vm/parser.cc#newcode3448 runtime/vm/parser.cc:3448: Type& mixin_application_type = Type::Handle(ParseMixins(mixin_super_type)); On 2013/02/26 22:49:54, ...

7 years, 10 months ago (2013-02-26 23:39:26 UTC) #3

hausner

7 years, 10 months ago (2013-02-26 23:39:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19097 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12340085: Progress in generic mixins (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages