Issue 12340072: dart:io | Enable tests of secure websocket connections.

Issue 12340072: dart:io | Enable tests of secure websocket connections. (Closed)

Created:
7 years, 9 months ago by Bill Hesse

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Enable tests of secure websocket connections. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19049

Patch Set 2 : Adjust _no_secure_ version and standalone.status. #

Patch Set 3 : Remove indentation FOR REVIEW ONLY. Intentation is restored in version to commit. #

Total comments: 5

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -156 lines)			Patch
M	sdk/lib/io/websocket.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/standalone/io/web_socket_no_secure_test.dart	View	1 2	9 chunks	+89 lines, -76 lines	4 comments	Download
M	tests/standalone/io/web_socket_test.dart	View	1 2	9 chunks	+98 lines, -76 lines	1 comment	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

I temporarily removed 2 spaces of indentation, so the review tool shows a better diff. ...

7 years, 9 months ago (2013-02-26 14:56:43 UTC) #1

Søren Gjesse

lgtm https://codereview.chromium.org/12340072/diff/5001/tests/standalone/io/web_socket_no_secure_test.dart File tests/standalone/io/web_socket_no_secure_test.dart (right): https://codereview.chromium.org/12340072/diff/5001/tests/standalone/io/web_socket_no_secure_test.dart#newcode65 tests/standalone/io/web_socket_no_secure_test.dart:65: webSocket.send(messageText); On 2013/02/26 14:56:43, Bill Hesse wrote: > ...

7 years, 9 months ago (2013-02-26 15:28:51 UTC) #2

Bill Hesse

Committed patchset #3 manually as r19049 (presubmit successful).

7 years, 9 months ago (2013-02-26 16:02:57 UTC) #3

Bill Hesse

7 years, 9 months ago (2013-02-26 16:09:50 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12340072/diff/5001/tests/standalone/io/web_so...
File tests/standalone/io/web_socket_no_secure_test.dart (right):

https://codereview.chromium.org/12340072/diff/5001/tests/standalone/io/web_so...
tests/standalone/io/web_socket_no_secure_test.dart:206: void
testW3CInterface(int totalConnections,
On 2013/02/26 15:28:51, Søren Gjesse wrote:
> Do we need this separate test anymore now that this is the only interface?

It is written differently, and tests different things, than the other tests, so
for the sake of diversity, we should keep it.

Expand Messages | Collapse Messages