dart2js: Add embedded globals to startup emitter.

dart2js: Add embedded globals to startup emitter.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/fd6e27c11d1948d21cbe45b4d126e0d2d46957bc

[floitsch, 2015-07-10 17:47:43]

floitsch@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-07-22 15:09:05]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-07-22 23:16:29]

lgtm

https://codereview.chromium.org/1233693002/diff/120001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1233693002/diff/120001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1042:
globalsObject)]))];
this makes me wonder if there are more features we should add to js.js to make
this simpler. For example, would it be helpful to have a notation to disallow
renames? for example:

js.js('var *init* = #', globalsObject);

[floitsch, 2015-07-29 17:47:59]

https://codereview.chromium.org/1233693002/diff/120001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1233693002/diff/120001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1042:
globalsObject)]))];
On 2015/07/22 23:16:29, Siggi Cherem (dart-lang) wrote:
> this makes me wonder if there are more features we should add to js.js to make
> this simpler. For example, would it be helpful to have a notation to disallow
> renames? for example:
> 
> js.js('var *init* = #', globalsObject);

I actually think that we should be able to rename it. Just didn't try it...
I think we only use the 'allowRename' only twice. So I wouldn't worry too much
about it.

[floitsch, 2015-08-03 15:34:28]

On 2015/07/29 17:47:59, floitsch wrote:
>
https://codereview.chromium.org/1233693002/diff/120001/pkg/compiler/lib/src/j...
> File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
> (right):
> 
>
https://codereview.chromium.org/1233693002/diff/120001/pkg/compiler/lib/src/j...
> pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1042:
> globalsObject)]))];
> On 2015/07/22 23:16:29, Siggi Cherem (dart-lang) wrote:
> > this makes me wonder if there are more features we should add to js.js to
make
> > this simpler. For example, would it be helpful to have a notation to
disallow
> > renames? for example:
> > 
> > js.js('var *init* = #', globalsObject);
> 
> I actually think that we should be able to rename it. Just didn't try it...
> I think we only use the 'allowRename' only twice. So I wouldn't worry too much
> about it.

as expected: 'init' can be renamed. I changed the code.

[floitsch, 2015-08-03 15:42:12]

Committed patchset #8 (id:140001) manually as
fd6e27c11d1948d21cbe45b4d126e0d2d46957bc (presubmit successful).