Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233533002: Respect gitignore for packages in subdirectories. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom, kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Respect gitignore for packages in subdirectories. Closes #1296 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/2bd839fe7f271eb78b7f12efd4e4b11a697ae98d

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -42 lines) Patch
M lib/src/package.dart View 1 2 chunks +20 lines, -1 line 2 comments Download
M test/package_list_files_test.dart View 12 chunks +78 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
5 years, 5 months ago (2015-07-10 00:20:47 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1233533002/diff/1/lib/src/package.dart File lib/src/package.dart (right): https://codereview.chromium.org/1233533002/diff/1/lib/src/package.dart#newcode112 lib/src/package.dart:112: bool get _usesGit { "uses" is kind of ...
5 years, 5 months ago (2015-07-10 00:34:34 UTC) #2
nweiz
Committed patchset #2 (id:20001) manually as 2bd839fe7f271eb78b7f12efd4e4b11a697ae98d (presubmit successful).
5 years, 5 months ago (2015-07-10 21:41:37 UTC) #3
nweiz
https://codereview.chromium.org/1233533002/diff/1/lib/src/package.dart File lib/src/package.dart (right): https://codereview.chromium.org/1233533002/diff/1/lib/src/package.dart#newcode112 lib/src/package.dart:112: bool get _usesGit { On 2015/07/10 00:34:34, Bob Nystrom ...
5 years, 5 months ago (2015-07-10 21:44:11 UTC) #4
kustermann
https://codereview.chromium.org/1233533002/diff/20001/lib/src/package.dart File lib/src/package.dart (right): https://codereview.chromium.org/1233533002/diff/20001/lib/src/package.dart#newcode206 lib/src/package.dart:206: /// account if the package's root directory is a ...
5 years, 3 months ago (2015-08-26 12:55:52 UTC) #6
nweiz
5 years, 3 months ago (2015-08-26 22:58:07 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1233533002/diff/20001/lib/src/package.dart
File lib/src/package.dart (right):

https://codereview.chromium.org/1233533002/diff/20001/lib/src/package.dart#ne...
lib/src/package.dart:206: /// account if the package's root directory is a Git
repository.
On 2015/08/26 12:55:52, kustermann wrote:
> dbc: This sentence is no longer correct. It also looks into the parent
directory
> chain.

Done in https://codereview.chromium.org/1310253007

Powered by Google App Engine
This is Rietveld 408576698