Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 12335138: Intrinsify OnebyteString's hashcode. Next step is to inline it. (Closed)

Created:
7 years, 9 months ago by srdjan
Modified:
7 years, 9 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Intrinsify OnebyteString's hashcode. Next step is to inline it. Committed: https://code.google.com/p/dart/source/detail?r=19182

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -0 lines) Patch
M runtime/lib/string_base.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 9 months ago (2013-02-27 17:22:00 UTC) #1
regis
LGTM
7 years, 9 months ago (2013-02-27 17:33:55 UTC) #2
srdjan
7 years, 9 months ago (2013-02-27 22:59:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r19182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698