Create "binaries" for calling the new analyzer.

Create "binaries" for calling the new analyzer.

This make the testing script look much nicer, and it allows for easier calling the analyzer instead of using java -jar
Committed: https://code.google.com/p/dart/source/detail?r=19882

[ricow1, 2013-02-27 13:51:35]

I did not test the windows version yet, I will do so when my machine is done
updating

[ahe, 2013-03-11 10:14:52]

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer
File editor/tools/analyzer (right):

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode1
editor/tools/analyzer:1: #!/bin/bash --posix
Any reason for the --posix parameter?

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode1
editor/tools/analyzer:1: #!/bin/bash --posix
I don't understand why this file is not in sdk/bin.

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode6
editor/tools/analyzer:6: # This file is copied to the output of the analyzer
under bin/
This is not a good overall description of this file.

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode9
editor/tools/analyzer:9: SCRIPT_DIR="$(cd "${0%/*}" ; pwd)"
This doesn't work with symlinks.  I'd start with sdk/bin/dart2js and make it do
what is needed here.

[kustermann, 2013-03-11 10:15:33]

lgtm

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer
File editor/tools/analyzer (right):

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode10
editor/tools/analyzer:10: JAR_DIR="$(cd "${SCRIPT_DIR%/*}" ; pwd)"
Add a comment here what this does and why we do it this way?

https://codereview.chromium.org/12335133/diff/1/editor/tools/compile_analyzer.py
File editor/tools/compile_analyzer.py (right):

https://codereview.chromium.org/12335133/diff/1/editor/tools/compile_analyzer...
editor/tools/compile_analyzer.py:75: unix_bin = os.path.dirname(__file__) +
"/analyzer"
You could use os.path.join.

[ricow1, 2013-03-12 08:41:41]

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer
File editor/tools/analyzer (right):

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode1
editor/tools/analyzer:1: #!/bin/bash --posix
On 2013/03/11 10:14:52, ahe wrote:
> I don't understand why this file is not in sdk/bin.
I don't think we are ready to ship this yet

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode1
editor/tools/analyzer:1: #!/bin/bash --posix
On 2013/03/11 10:14:52, ahe wrote:
> Any reason for the --posix parameter?
removed

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode6
editor/tools/analyzer:6: # This file is copied to the output of the analyzer
under bin/
On 2013/03/11 10:14:52, ahe wrote:
> This is not a good overall description of this file.

Done.

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode9
editor/tools/analyzer:9: SCRIPT_DIR="$(cd "${0%/*}" ; pwd)"
On 2013/03/11 10:14:52, ahe wrote:
> This doesn't work with symlinks.  I'd start with sdk/bin/dart2js and make it
do
> what is needed here.

Done.

[kustermann, 2013-03-12 08:45:17]

https://codereview.chromium.org/12335133/diff/7001/editor/tools/compile_analy...
File editor/tools/compile_analyzer.py (right):

https://codereview.chromium.org/12335133/diff/7001/editor/tools/compile_analy...
editor/tools/compile_analyzer.py:77: print unix_bin
Left over "print"s?

[ahe, 2013-03-12 08:47:35]

Still troubled by this file not being in sdk/bin.

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer
File editor/tools/analyzer (right):

https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode1
editor/tools/analyzer:1: #!/bin/bash --posix
On 2013/03/12 08:41:41, ricow1 wrote:
> On 2013/03/11 10:14:52, ahe wrote:
> > I don't understand why this file is not in sdk/bin.
> I don't think we are ready to ship this yet

Perhaps you could exclude the file in create_sdk.

https://codereview.chromium.org/12335133/diff/1/editor/tools/compile_analyzer.py
File editor/tools/compile_analyzer.py (right):

https://codereview.chromium.org/12335133/diff/1/editor/tools/compile_analyzer...
editor/tools/compile_analyzer.py:75: unix_bin = os.path.dirname(__file__) +
"/analyzer"
On 2013/03/11 10:15:33, kustermann wrote:
> You could use os.path.join.

*should*, I think :-)

[ricow1, 2013-03-12 10:59:06]

On 2013/03/12 08:47:35, ahe wrote:
> Still troubled by this file not being in sdk/bin.
I misunderstood your intent, moving it to sdk/bin

> 
> https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer
> File editor/tools/analyzer (right):
> 
> https://codereview.chromium.org/12335133/diff/1/editor/tools/analyzer#newcode1
> editor/tools/analyzer:1: #!/bin/bash --posix
> On 2013/03/12 08:41:41, ricow1 wrote:
> > On 2013/03/11 10:14:52, ahe wrote:
> > > I don't understand why this file is not in sdk/bin.
> > I don't think we are ready to ship this yet
> 
> Perhaps you could exclude the file in create_sdk.
> 
>
https://codereview.chromium.org/12335133/diff/1/editor/tools/compile_analyzer.py
> File editor/tools/compile_analyzer.py (right):
> 
>
https://codereview.chromium.org/12335133/diff/1/editor/tools/compile_analyzer...
> editor/tools/compile_analyzer.py:75: unix_bin = os.path.dirname(__file__) +
> "/analyzer"
> On 2013/03/11 10:15:33, kustermann wrote:
> > You could use os.path.join.
> 
> *should*, I think :-)

[ricow1, 2013-03-12 13:26:04]

Moved bash file to sdk/bin
This is not executable from that location - if we want that we need to
explicitly state the path to the output directory from here.

[ahe, 2013-03-12 14:13:11]

https://codereview.chromium.org/12335133/diff/3002/editor/tools/compile_analy...
File editor/tools/compile_analyzer.py (right):

https://codereview.chromium.org/12335133/diff/3002/editor/tools/compile_analy...
editor/tools/compile_analyzer.py:77: def CopyBinaries(options):
Why do you need to copy the "binaries"?

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer
File sdk/bin/analyzer (right):

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer#newcode9
sdk/bin/analyzer:9: # This file is copied to the output of the analyzer under
bin/ by the
Why is that necessary?

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer.bat
File sdk/bin/analyzer.bat (right):

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer.bat#newcode7
sdk/bin/analyzer.bat:7: rem This file is copied to the output of the analyzer
under bin/
Not really documentation.

[ricow1, 2013-03-12 15:28:55]

PTAL

https://codereview.chromium.org/12335133/diff/3002/editor/tools/compile_analy...
File editor/tools/compile_analyzer.py (right):

https://codereview.chromium.org/12335133/diff/3002/editor/tools/compile_analy...
editor/tools/compile_analyzer.py:77: def CopyBinaries(options):
On 2013/03/12 14:13:11, ahe wrote:
> Why do you need to copy the "binaries"?
That is a good point - I originally did not want to locate sdk/bin from the
testing script, but we already do that for dart2js

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer
File sdk/bin/analyzer (right):

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer#newcode9
sdk/bin/analyzer:9: # This file is copied to the output of the analyzer under
bin/ by the
On 2013/03/12 14:13:11, ahe wrote:
> Why is that necessary?

It is not

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer.bat
File sdk/bin/analyzer.bat (right):

https://codereview.chromium.org/12335133/diff/3002/sdk/bin/analyzer.bat#newcode7
sdk/bin/analyzer.bat:7: rem This file is copied to the output of the analyzer
under bin/
On 2013/03/12 14:13:11, ahe wrote:
> Not really documentation.
Changed

[ahe, 2013-03-12 15:47:04]

LGTM!

https://codereview.chromium.org/12335133/diff/27002/editor/analyzer.gyp
File editor/analyzer.gyp (right):

https://codereview.chromium.org/12335133/diff/27002/editor/analyzer.gyp#newco...
editor/analyzer.gyp:37: '../sdk/bin/analyzer.bat'
I'm not sure you need these as dependencies anymore.

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer
File sdk/bin/analyzer (right):

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer#newcode6
sdk/bin/analyzer:6: # This file is used to execute the analyzer by running the
jar file
Unfinished sentence (add a period).

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer.bat
File sdk/bin/analyzer.bat (right):

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer.bat#newc...
sdk/bin/analyzer.bat:14: if %SCRIPTPATH:~-1%== set SCRIPTPATH=%SCRIPTPATH:~0,-1%
This reminds me.  I think there is a cut-and-paste error here.  Shouldn't it be:

if %SCRIPTPATH:~-1%==\ set SCRIPTPATH=%SCRIPTPATH:~0,-1%

[ricow1, 2013-03-12 17:42:21]

Committed patchset #9 manually as r19882 (presubmit successful).

[ricow1, 2013-03-12 18:08:40]

https://codereview.chromium.org/12335133/diff/27002/editor/analyzer.gyp
File editor/analyzer.gyp (right):

https://codereview.chromium.org/12335133/diff/27002/editor/analyzer.gyp#newco...
editor/analyzer.gyp:37: '../sdk/bin/analyzer.bat'
On 2013/03/12 15:47:04, ahe wrote:
> I'm not sure you need these as dependencies anymore.

removed

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer
File sdk/bin/analyzer (right):

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer#newcode6
sdk/bin/analyzer:6: # This file is used to execute the analyzer by running the
jar file
On 2013/03/12 15:47:04, ahe wrote:
> Unfinished sentence (add a period).

Done. and in windows as well

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer.bat
File sdk/bin/analyzer.bat (right):

https://codereview.chromium.org/12335133/diff/27002/sdk/bin/analyzer.bat#newc...
sdk/bin/analyzer.bat:14: if %SCRIPTPATH:~-1%== set SCRIPTPATH=%SCRIPTPATH:~0,-1%
On 2013/03/12 15:47:04, ahe wrote:
> This reminds me.  I think there is a cut-and-paste error here.  Shouldn't it
be:
> 
> if %SCRIPTPATH:~-1%==\ set SCRIPTPATH=%SCRIPTPATH:~0,-1%

Yes, thanks