Unit test changes:

Unit test changes:

- add back KevMoo's assertions now that the bugs they exposed ar efixed
- remove onTestResult methods from a couple of configs; these did nothing other
  than prevent the base class implementation from being called which is wrong.
- fix the TestFunction signature
- change from ExpectException, which is deprecated, to TestFailure.
Committed: https://code.google.com/p/dart/source/detail?r=19166

[gram, 2013-02-27 00:31:40]

Bob, PTAL at the TestFailure stuff, and see if you are okay with it. We
discussed using StateError, but there are benefits to having a type specific to
test failures.

[Siggi Cherem (dart-lang), 2013-02-27 00:40:03]

https://codereview.chromium.org/12335113/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/12335113/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:776: String message = (e is Exception) ?
e.message : 'Caught $e';
is TestFailure?

(e.message doesn't exist in the default Exception class)

https://codereview.chromium.org/12335113/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:894: typedef Future TestFunction();
I think this is fine, but I wonder if we might wan this  to be dynamic instead.

'null' is a valid future return value, but there are two meanings for what it
does: if the result is not a future, then we get the old behavior.

[gram, 2013-02-27 00:56:13]

https://codereview.chromium.org/12335113/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/12335113/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:776: String message = (e is Exception) ?
e.message : 'Caught $e';
On 2013/02/27 00:40:03, Siggi Cherem (dart-lang) wrote:
> is TestFailure?
> 
> (e.message doesn't exist in the default Exception class)

Done.

https://codereview.chromium.org/12335113/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:894: typedef Future TestFunction();
On 2013/02/27 00:40:03, Siggi Cherem (dart-lang) wrote:
> I think this is fine, but I wonder if we might wan this  to be dynamic
instead.
> 
> 'null' is a valid future return value, but there are two meanings for what it
> does: if the result is not a future, then we get the old behavior.

Done.

[Bob Nystrom, 2013-02-27 19:23:56]

Naming quibble but otherwise LGTM. When you check this in, can you grep pub for
"ExceptException" and change those too? You can test pub using:

$ ./tools/test.py -m release --checked pub

https://codereview.chromium.org/12335113/diff/3001/pkg/unittest/lib/src/expec...
File pkg/unittest/lib/src/expect.dart (right):

https://codereview.chromium.org/12335113/diff/3001/pkg/unittest/lib/src/expec...
pkg/unittest/lib/src/expect.dart:8: class TestFailure implements Exception {
I'd like it if "Exception" was in the class name. Maybe "TestException"? Why not
just keep it "ExpectException"?

[gram, 2013-02-27 19:57:45]

Committed patchset #3 manually as r19166 (presubmit successful).