Handle shared path dependencies.

Handle shared path dependencies.

BUG=https://code.google.com/p/dart/issues/detail?id=8775

Committed: https://code.google.com/p/dart/source/detail?r=19012

[nweiz, 2013-02-25 22:08:46]

https://codereview.chromium.org/12335076/diff/1/utils/pub/path_source.dart
File utils/pub/path_source.dart (right):

https://codereview.chromium.org/12335076/diff/1/utils/pub/path_source.dart#ne...
utils/pub/path_source.dart:36: // TODO(rnystrom): Traverse symlinks and compare
real paths?
I'm leaning towards yes.

https://codereview.chromium.org/12335076/diff/1/utils/pub/path_source.dart#ne...
utils/pub/path_source.dart:40: description1["relative"] ==
description2["relative"];
I don't think this is correct. If both paths resolve to the same location,
they're always pointing to the same package, regardless if one is relative and
the other isn't.

https://codereview.chromium.org/12335076/diff/1/utils/tests/pub/install/path/...
File utils/tests/pub/install/path/shared_dependency_test.dart (right):

https://codereview.chromium.org/12335076/diff/1/utils/tests/pub/install/path/...
utils/tests/pub/install/path/shared_dependency_test.dart:102: }
Test that an absolute path and a relative path that normalize the same work
together. Also test that it works through symlinks if you end up implementing
that in this CL.

[Bob Nystrom, 2013-02-25 22:50:26]

https://codereview.chromium.org/12335076/diff/1/utils/pub/path_source.dart
File utils/pub/path_source.dart (right):

https://codereview.chromium.org/12335076/diff/1/utils/pub/path_source.dart#ne...
utils/pub/path_source.dart:36: // TODO(rnystrom): Traverse symlinks and compare
real paths?
On 2013/02/25 22:08:46, nweiz wrote:
> I'm leaning towards yes.

Done.

https://codereview.chromium.org/12335076/diff/1/utils/pub/path_source.dart#ne...
utils/pub/path_source.dart:40: description1["relative"] ==
description2["relative"];
On 2013/02/25 22:08:46, nweiz wrote:
> I don't think this is correct. If both paths resolve to the same location,
> they're always pointing to the same package, regardless if one is relative and
> the other isn't.

Done.

https://codereview.chromium.org/12335076/diff/1/utils/tests/pub/install/path/...
File utils/tests/pub/install/path/shared_dependency_test.dart (right):

https://codereview.chromium.org/12335076/diff/1/utils/tests/pub/install/path/...
utils/tests/pub/install/path/shared_dependency_test.dart:102: }
On 2013/02/25 22:08:46, nweiz wrote:
> Test that an absolute path and a relative path that normalize the same work
> together.

Done.

> Also test that it works through symlinks if you end up implementing
> that in this CL.

Done.

[nweiz, 2013-02-25 22:57:04]

One question, but LGTM.

https://codereview.chromium.org/12335076/diff/4002/utils/tests/pub/install/pa...
File utils/tests/pub/install/path/shared_dependency_test.dart (right):

https://codereview.chromium.org/12335076/diff/4002/utils/tests/pub/install/pa...
utils/tests/pub/install/path/shared_dependency_test.dart:131:
integration("shared dependency with symlink", () {
Is this going to break on Windows?

[Bob Nystrom, 2013-02-25 23:00:03]

https://codereview.chromium.org/12335076/diff/4002/utils/tests/pub/install/pa...
File utils/tests/pub/install/path/shared_dependency_test.dart (right):

https://codereview.chromium.org/12335076/diff/4002/utils/tests/pub/install/pa...
utils/tests/pub/install/path/shared_dependency_test.dart:131:
integration("shared dependency with symlink", () {
On 2013/02/25 22:57:04, nweiz wrote:
> Is this going to break on Windows?

I don't believe so, but we'll find out. :)

[Bob Nystrom, 2013-02-25 23:00:28]

Committed patchset #2 manually as r19012 (presubmit successful).