Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 12335071: Issue 8705. Fix for NPE when use method from mixin inside of class. (Closed)

Created:
7 years, 10 months ago by scheglov
Modified:
7 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -79 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ClassScope.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/MixinScope.java View 2 chunks +5 lines, -5 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 71 chunks +89 lines, -70 lines 0 comments Download
M editor/tools/plugins/com.google.dart.compiler.js_test/.settings/org.eclipse.jdt.core.prefs View 2 chunks +280 lines, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.compiler.js_test/.settings/org.eclipse.jdt.ui.prefs View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 10 months ago (2013-02-25 20:14:05 UTC) #1
Brian Wilkerson
LGTM
7 years, 10 months ago (2013-02-25 20:19:40 UTC) #2
scheglov
7 years, 10 months ago (2013-02-25 22:56:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698