Issue 12335063: Add functions for setting an environment and rebinding a use.

Issue 12335063: Add functions for setting an environment and rebinding a use. (Closed)

Created:
7 years, 10 months ago by Kevin Millikin (Google)

Modified:
7 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add functions for setting an environment and rebinding a use. Add functions for setting or clearing an instruction's environment, which initialize the environment uses. Add a function for changing a use's definition. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=19036

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased and incorportated review comments. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -120 lines)			Patch
M	runtime/vm/compiler.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph.cc	View		4 chunks	+3 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1	1 chunk	+16 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	16 chunks	+21 lines, -41 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		5 chunks	+21 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	12 chunks	+44 lines, -44 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

DBC https://codereview.chromium.org/12335063/diff/1/runtime/vm/flow_graph_optimizer.h File runtime/vm/flow_graph_optimizer.h (right): https://codereview.chromium.org/12335063/diff/1/runtime/vm/flow_graph_optimizer.h#newcode165 runtime/vm/flow_graph_optimizer.h:165: class LICM { public ValueObject

7 years, 10 months ago (2013-02-25 18:48:50 UTC) #2

Kevin Millikin (Google)

https://codereview.chromium.org/12335063/diff/1/runtime/vm/flow_graph_optimizer.h File runtime/vm/flow_graph_optimizer.h (right): https://codereview.chromium.org/12335063/diff/1/runtime/vm/flow_graph_optimizer.h#newcode165 runtime/vm/flow_graph_optimizer.h:165: class LICM { On 2013/02/25 18:48:50, srdjan wrote: > ...

7 years, 10 months ago (2013-02-26 08:22:23 UTC) #3

Kevin Millikin (Google)

7 years, 10 months ago (2013-02-26 11:50:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19036 (presubmit successful).

Expand Messages | Collapse Messages