Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 12335035: Fix use of stringbuffer in pkg/args (Closed)

Created:
7 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 10 months ago
Reviewers:
Bob Nystrom, dgrove
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix use of stringbuffer in pkg/args Committed: https://code.google.com/p/dart/source/detail?r=18902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M pkg/args/lib/src/usage.dart View 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
StringBuffer.add is deprecated =(
7 years, 10 months ago (2013-02-22 18:19:33 UTC) #1
dgrove
lgtm
7 years, 10 months ago (2013-02-22 18:20:19 UTC) #2
Siggi Cherem (dart-lang)
7 years, 10 months ago (2013-02-22 18:21:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698