Issue 12334117: Fix http_close_test to wait for server close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12334117: Fix http_close_test to wait for server close. (Closed)

Created:
7 years, 9 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix http_close_test to wait for server close. The client can receive data before the server is aware the data is sent. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19113

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
	M	tests/standalone/io/http_close_test.dart	View	1	2 chunks	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12334117/diff/1/tests/standalone/io/http_close_test.dart File tests/standalone/io/http_close_test.dart (right): https://codereview.chromium.org/12334117/diff/1/tests/standalone/io/http_close_test.dart#newcode76 tests/standalone/io/http_close_test.dart:76: // Wait for both server and client to ...

7 years, 9 months ago (2013-02-27 08:46:53 UTC) #2

Anders Johnsen

Committed patchset #2 manually as r19113 (presubmit successful).

7 years, 9 months ago (2013-02-27 08:58:02 UTC) #3

Anders Johnsen

7 years, 6 months ago (2013-06-11 12:21:50 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12334117/diff/1/tests/standalone/io/http_clos...
File tests/standalone/io/http_close_test.dart (right):

https://codereview.chromium.org/12334117/diff/1/tests/standalone/io/http_clos...
tests/standalone/io/http_close_test.dart:76: // Wait for both server and client
to see the connection as closed.
On 2013/02/27 08:46:53, Søren Gjesse wrote:
> connection -> connections

Done.

Expand Messages | Collapse Messages

Issue 12334117: Fix http_close_test to wait for server close. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages