Issue 12334098: Added library comment and warning message to web_sql.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12334098: Added library comment and warning message to web_sql. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski

Modified:
7 years, 10 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added library comment and warning message to web_sql. Committed: https://code.google.com/p/dart/source/detail?r=19092

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -0 lines)			Patch
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate	View	1 chunk	+11 lines, -0 lines	1 comment	Download
M	tools/dom/templates/html/dartium/web_sql_dartium.darttemplate	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm with comment. https://codereview.chromium.org/12334098/diff/1/tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate File tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate (right): https://codereview.chromium.org/12334098/diff/1/tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate#newcode13 tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate:13: * The [dart:html.Storage] or [dart:indexed_db] APIs ...

7 years, 10 months ago (2013-02-26 20:55:12 UTC) #2

Andrei Mouravski

7 years, 10 months ago (2013-02-26 22:37:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19092 (presubmit successful).

Expand Messages | Collapse Messages