Stop creating selectors in the SSA builder that were already created by the resolver.

Stop creating selectors in the SSA builder that were already created by the resolver.
Committed: https://code.google.com/p/dart/source/detail?r=19131

[kasperl, 2013-02-27 10:11:27]

LGTM.

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:92: // and we
arbritraly choose which ones.
arbitrarily

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2298:
setter.getEnclosingClass().lookupMember(const SourceString('[]'));
Seems more logical to use the enclosing class of the field (even though that
should be the same, right?).

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2301:
warnAndCreateErroneousElement(node, setter.name,
Move the warnAnd...( part to the previous line (like done in line 2010) because
it looks nicer? Maybe do that in more places?

[ngeoffray, 2013-02-27 12:23:58]

Thanks Kasper. I will follow up with another CL for the getter/setter not in the
same class problem.

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:92: // and we
arbritraly choose which ones.
On 2013/02/27 10:11:28, kasperl wrote:
> arbitrarily 

Done.

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2298:
setter.getEnclosingClass().lookupMember(const SourceString('[]'));
On 2013/02/27 10:11:28, kasperl wrote:
> Seems more logical to use the enclosing class of the field (even though that
> should be the same, right?).

Yes, it's the same. Replaced to use target.

https://codereview.chromium.org/12334088/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2301:
warnAndCreateErroneousElement(node, setter.name,
On 2013/02/27 10:11:28, kasperl wrote:
> Move the warnAnd...( part to the previous line (like done in line 2010)
because
> it looks nicer? Maybe do that in more places?

Done.

[ngeoffray, 2013-02-27 13:19:02]

Committed patchset #3 manually as r19131 (presubmit successful).