Issue 12334081: Fixing web_sql SqlResultSetRowList row accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12334081: Fixing web_sql SqlResultSetRowList row accessor. (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing web_sql SqlResultSetRowList row accessor. Basically the JS generated code is using indexed getters even when they are not available and alternate methods should be used. BUG=8666 Committed: https://code.google.com/p/dart/source/detail?r=19055

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -51 lines)			Patch
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/websql_test.dart	View	5 chunks	+50 lines, -40 lines	1 comment	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+21 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/12334081/diff/1/tests/html/websql_test.dart File tests/html/websql_test.dart (right): https://codereview.chromium.org/12334081/diff/1/tests/html/websql_test.dart#newcode142 tests/html/websql_test.dart:142: expect(resultSet.rows[0], row); This is actually the only line needed ...

7 years, 10 months ago (2013-02-25 23:48:31 UTC) #1

blois

7 years, 10 months ago (2013-02-26 16:59:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19055 (presubmit successful).

Expand Messages | Collapse Messages