Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 12334080: For Doubl erounding call C-function instead of attempting to inline it. Fixes issue 8760. (Closed)

Created:
7 years, 10 months ago by srdjan
Modified:
7 years, 10 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

For Doubl erounding call C-function instead of attempting to inline it. Fixes issue 8760. Committed: https://code.google.com/p/dart/source/detail?r=19013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -171 lines) Patch
M runtime/vm/assembler_ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +1 line, -10 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +1 line, -10 lines 0 comments Download
M sdk/lib/scalarlist/simd128.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/arithmetic_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 10 months ago (2013-02-25 22:40:25 UTC) #1
regis
LGTM
7 years, 10 months ago (2013-02-25 23:01:39 UTC) #2
srdjan
7 years, 10 months ago (2013-02-25 23:05:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19013 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698