Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 12334010: Fix dart2js analyze _api_test for dart:io (Closed)

Created:
7 years, 10 months ago by Søren Gjesse
Modified:
7 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix dart2js analyze _api_test for dart:io R=johnniwinther@google.com BUG=https://code.google.com/p/dart/issues/detail?id=8394 Committed: https://code.google.com/p/dart/source/detail?r=18867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M sdk/lib/io/http_headers.dart View 2 chunks +21 lines, -17 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/timer_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 10 months ago (2013-02-21 15:49:58 UTC) #1
Johnni Winther
lgtm
7 years, 10 months ago (2013-02-21 16:54:49 UTC) #2
Søren Gjesse
7 years, 10 months ago (2013-02-22 08:23:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698