Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1233243006: Print child process' stderr when it fails in full_coverage_test. (Closed)

Created:
5 years, 5 months ago by koda
Modified:
5 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print child process' stderr when it fails in full_coverage_test. In general, doing this for tests that fork helps with debugging build bot failures. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/0bbf08a164232a5b6e0dbb75574ef507e4b4c468

Patch Set 1 #

Patch Set 2 : Utf8Codec #

Patch Set 3 : Default encoding, newlines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tests/standalone/full_coverage_test.dart View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 5 months ago (2015-07-17 16:13:09 UTC) #2
rmacnak
lgtm
5 years, 5 months ago (2015-07-17 17:04:55 UTC) #3
koda
5 years, 5 months ago (2015-07-17 17:33:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0bbf08a164232a5b6e0dbb75574ef507e4b4c468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698