Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1233053002: Make random clicks in the debugger give the command line input focus. (Closed)

Created:
5 years, 5 months ago by turnidge
Modified:
5 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org, iansf
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make random clicks in the debugger give the command line input focus. If the user selects a range, respect that. Add some inner spacing on the command line input box. Makes it feel less claustrophobic. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a02c7694c5d756b1f1da4f1dc8e4efaa5ef09a1d

Patch Set 1 #

Patch Set 2 : before submit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 5 months ago (2015-07-14 00:49:37 UTC) #2
turnidge
5 years, 5 months ago (2015-07-14 00:59:04 UTC) #3
rmacnak
lgtm
5 years, 5 months ago (2015-07-14 01:12:09 UTC) #4
turnidge
5 years, 5 months ago (2015-07-14 19:35:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a02c7694c5d756b1f1da4f1dc8e4efaa5ef09a1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698