Issue 12330139: Increase timeout jitter - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(2)

My Issues | Starred Open | Closed | All

Issue 12330139: Increase timeout jitter (Closed)

Created:
7 years, 10 months ago by Søren Gjesse

Modified:
7 years, 9 months ago

Reviewers:
Mads Ager (google), siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Increase timeout jitter Test have been failing on Windows a couple of times, e.g http://build.chromium.org/p/client.dart/builders/vm-win32-release/builds/12880/steps/tests/logs/stdio R=asiva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19127

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/os_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Mads could you take a look? This keeps falking on Windows.

7 years, 9 months ago (2013-02-27 12:13:36 UTC) #2

Mads Ager (google)

LGTM Timing based tests like these are flaky by definition.

7 years, 9 months ago (2013-02-27 12:16:26 UTC) #3

Søren Gjesse

Committed patchset #1 manually as r19127 (presubmit successful).

7 years, 9 months ago (2013-02-27 12:51:28 UTC) #4

Message was sent while issue was closed.

Oops sorry this slipped through.
LGTM.

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698