Issue 12330133: Don't use external servers in the tests

Issue 12330133: Don't use external servers in the tests (Closed)

Created:
7 years, 10 months ago by Søren Gjesse

Modified:
7 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't use external servers in the tests The use of external servers can lead to unwanted flakiness. The socket reuse tests where removed alltogether as they where not testing socket reuse anymore than a lot of the other HTTP/HTTPS tests. This change revealed some issues with srcure sockets and short writes, so the short writes are disabled until this is resolved. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19032

Patch Set 1 #

Patch Set 2 : Fixed long lines #

Total comments: 4

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -337 lines)			Patch
A	tests/standalone/io/http_client_exception_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download
D	tests/standalone/io/http_client_socket_reuse_test.dart	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	tests/standalone/io/http_client_test.dart	View		1 chunk	+0 lines, -75 lines	0 comments	Download
A	tests/standalone/io/https_client_exception_test.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download
D	tests/standalone/io/https_client_socket_reuse_test.dart	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	tests/standalone/io/https_client_test.dart	View		1 chunk	+0 lines, -60 lines	0 comments	Download
M	tests/standalone/io/raw_secure_socket_pause_test.dart	View	1	1 chunk	+89 lines, -63 lines	2 comments	Download
M	tests/standalone/io/raw_secure_socket_test.dart	View	1	1 chunk	+62 lines, -32 lines	2 comments	Download
M	tests/standalone/io/secure_socket_test.dart	View	1	1 chunk	+50 lines, -21 lines	0 comments	Download
M	tests/standalone/standalone.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM! https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_secure_socket_pause_test.dart File tests/standalone/io/raw_secure_socket_pause_test.dart (right): https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_secure_socket_pause_test.dart#newcode7 tests/standalone/io/raw_secure_socket_pause_test.dart:7: // XXVMOptions=--short_socket_write XX? https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_secure_socket_test.dart File tests/standalone/io/raw_secure_socket_test.dart (right): https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_secure_socket_test.dart#newcode7 ...

7 years, 10 months ago (2013-02-26 09:42:14 UTC) #2

Søren Gjesse

Committed patchset #2 manually as r19032 (presubmit successful).

7 years, 10 months ago (2013-02-26 09:48:58 UTC) #3

Søren Gjesse

7 years, 10 months ago (2013-02-26 10:00:00 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_se...
File tests/standalone/io/raw_secure_socket_pause_test.dart (right):

https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_se...
tests/standalone/io/raw_secure_socket_pause_test.dart:7: //
XXVMOptions=--short_socket_write
On 2013/02/26 09:42:14, Anders Johnsen wrote:
> XX?

This was the simple way to disable short socket writes. I deleted the lines
instead.

https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_se...
File tests/standalone/io/raw_secure_socket_test.dart (right):

https://codereview.chromium.org/12330133/diff/3001/tests/standalone/io/raw_se...
tests/standalone/io/raw_secure_socket_test.dart:7: //
XXVMOptions=--short_socket_write
On 2013/02/26 09:42:14, Anders Johnsen wrote:
> XX?

Ditto.

Expand Messages | Collapse Messages