Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 12330120: Add an async descriptor to scheduled_test. (Closed)

Created:
7 years, 10 months ago by nweiz
Modified:
7 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an async descriptor to scheduled_test. BUG=8511 Committed: https://code.google.com/p/dart/source/detail?r=19008

Patch Set 1 #

Patch Set 2 : Windows compatibility #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -0 lines) Patch
M pkg/scheduled_test/lib/descriptor.dart View 2 chunks +6 lines, -0 lines 0 comments Download
A pkg/scheduled_test/lib/src/descriptor/async.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/descriptor_test.dart View 1 2 chunks +127 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 10 months ago (2013-02-25 21:37:07 UTC) #1
Bob Nystrom
LGTM
7 years, 10 months ago (2013-02-25 22:06:26 UTC) #2
nweiz
7 years, 10 months ago (2013-02-25 22:10:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698