Issue 12330113: null value can be the receiver of methods on Object (e.g. hashCode).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12330113: null value can be the receiver of methods on Object (e.g. hashCode). (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

null value can be the receiver of methods on Object (e.g. hashCode). Fix wrong assumption in the type propagator that marked the receiver as never nullable. R=srdjan@google.com BUG=dart:8739 Committed: https://code.google.com/p/dart/source/detail?r=18991

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -24 lines)			Patch
M	runtime/vm/compiler.cc	View	3 chunks	+2 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	4 chunks	+10 lines, -9 lines	0 comments	Download
M	runtime/vm/il_printer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	tests/language/null_hashcode_optimized_vm_test.dart	View	1 chunk	+7 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Google)

7 years, 10 months ago (2013-02-25 18:49:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18991 (presubmit successful).