Issue 12330074: Fix some dart:io documentation comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12330074: Fix some dart:io documentation comments. (Closed)

Created:
7 years, 10 months ago by Bill Hesse

Modified:
7 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some dart:io documentation comments. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18968

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -77 lines)			Patch
M	sdk/lib/async/stream.dart	View	14 chunks	+16 lines, -16 lines	0 comments	Download
M	sdk/lib/io/http.dart	View	23 chunks	+56 lines, -55 lines	0 comments	Download
M	sdk/lib/io/process.dart	View	4 chunks	+5 lines, -5 lines	2 comments	Download
M	sdk/lib/io/socket.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12330074/diff/1/sdk/lib/io/process.dart File sdk/lib/io/process.dart (right): https://codereview.chromium.org/12330074/diff/1/sdk/lib/io/process.dart#newcode82 sdk/lib/io/process.dart:82: * Returns the standard output stream of the ...

7 years, 10 months ago (2013-02-25 09:15:05 UTC) #2

Bill Hesse

Committed patchset #1 manually as r18968 (presubmit successful).

7 years, 10 months ago (2013-02-25 14:47:51 UTC) #3

Bill Hesse

7 years, 10 months ago (2013-02-25 14:55:25 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12330074/diff/1/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/12330074/diff/1/sdk/lib/io/process.dart#newco...
sdk/lib/io/process.dart:82: * Returns the standard output stream of the process
as a [:Stream:].
On 2013/02/25 09:15:05, Søren Gjesse wrote:
> For consistency either remove ::'s here or add them to [IOSink].

But IOSink is a class in this library, and the link works.

Expand Messages | Collapse Messages