Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1233003002: Only send "analysis.analyzedFiles" notification when the set of files changes. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org, Brian Wilkerson
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only send "analysis.analyzedFiles" notification when the set of files changes. R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/2f6ebaa7740bbcf281273118d402bc3223fe8fa2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +15 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart View 5 chunks +53 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-07-13 22:49:13 UTC) #2
jwren
On 2015/07/13 22:49:13, Paul Berry wrote: LGTM
5 years, 5 months ago (2015-07-13 22:51:51 UTC) #3
Paul Berry
5 years, 5 months ago (2015-07-13 22:52:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f6ebaa7740bbcf281273118d402bc3223fe8fa2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698