Issue 12328143: pkg/unittest: Moved `fail` to matcher library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12328143: pkg/unittest: Moved `fail` to matcher library (Closed)

Created:
7 years, 9 months ago by kevmoo-old

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom, gram

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Aligns with usage of FailureHandler and behavior of expect Eliminates call: expect(false, isTrue, reason: ...) BUG= https://code.google.com/p/dart/issues/detail?id=8450 Committed: https://code.google.com/p/dart/source/detail?r=19168

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -13 lines)			Patch
M	pkg/unittest/lib/src/core_matchers.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/unittest/lib/src/expect.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/unittest/lib/src/future_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/unittest/test/unittest_test.dart	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (0 generated)

kevmoo-old

Updated to align with r19166 If it lgty, please commit.

7 years, 9 months ago (2013-02-27 20:02:54 UTC) #4

gram

7 years, 9 months ago (2013-02-27 20:51:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19168 (presubmit successful).