Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 12328122: Used Socket::Read instead of FdUtils::ReadFromBlocking, since FdUtils (Closed)

Created:
7 years, 10 months ago by Tom Ball
Modified:
7 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Used Socket::Read instead of FdUtils::ReadFromBlocking, since FdUtils isn't implemented on Windows. Committed: https://code.google.com/p/dart/source/detail?r=19098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M runtime/bin/vmstats_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Ball
7 years, 10 months ago (2013-02-26 23:39:11 UTC) #1
Tom Ball
7 years, 10 months ago (2013-02-26 23:40:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698