Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 12328114: Rewrite the Future-pipeline from the Socket to the HttpClientRequest/HttpResponse. (Closed)

Created:
7 years, 10 months ago by Anders Johnsen
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org, Bill Hesse, ricow1
Visibility:
Public.

Description

Rewrite the Future-pipeline from the Socket to the HttpClientRequest/HttpResponse. Before we had two future, HttpClientRequest/HttpResponse.done and Socket.addStream's return valud(stored as _writeDoneFuture in http_impl). Many issues in our code was based on the futures not being the same, that the user will get a done event, while the socket is still writing data on the socket. Immidiate calls to HttpServer/HttpClient.close, after e.g. pipe, would then destroy the socket while still having data in dart buffers. The new approach makes sure that there is a direct future link between the socket and the user. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19111

Patch Set 1 #

Patch Set 2 : Add missing test file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -169 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 11 chunks +113 lines, -168 lines 0 comments Download
M sdk/lib/io/io_stream_consumer.dart View 2 chunks +9 lines, -1 line 0 comments Download
A tests/standalone/io/http_close_test.dart View 1 1 chunk +112 lines, -0 lines 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 10 months ago (2013-02-26 21:04:29 UTC) #1
Søren Gjesse
LGTM!
7 years, 9 months ago (2013-02-27 08:23:09 UTC) #2
Anders Johnsen
7 years, 9 months ago (2013-02-27 08:27:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698