Improve perfromance of integer parsing for Smi-s.

Improve perfromance of integer parsing for Smi-s.
Committed: https://code.google.com/p/dart/source/detail?r=18990

[siva, 2013-02-25 06:22:44]

https://codereview.chromium.org/12328068/diff/6001/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/12328068/diff/6001/runtime/lib/integers.cc#ne...
runtime/lib/integers.cc:197: if (p_end == (cstr + len)) {
Should this be if (cstr + strlen(cstr)) because if we had some non ASCII
characters strlen(cstr) will be greater than len.

or you could have a check
if ((cstr[0] != '+') && strlen(cstr) == len) {
  ...
  ...
}

[srdjan, 2013-02-25 18:02:44]

https://codereview.chromium.org/12328068/diff/6001/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/12328068/diff/6001/runtime/lib/integers.cc#ne...
runtime/lib/integers.cc:197: if (p_end == (cstr + len)) {
On 2013/02/25 06:22:44, siva wrote:
> Should this be if (cstr + strlen(cstr)) because if we had some non ASCII
> characters strlen(cstr) will be greater than len.
> 
> or you could have a check
> if ((cstr[0] != '+') && strlen(cstr) == len) {
>   ...
>   ...
> }

strlen is slow and we cannot have a valid double with non-ASCII characters.

[siva, 2013-02-25 18:14:09]

LGTM after offline discussion.

[srdjan, 2013-02-25 18:36:20]

Committed patchset #4 manually as r18990 (presubmit successful).