Issue 12328052: Handle single EPOLLHUP epoll events on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12328052: Handle single EPOLLHUP epoll events on Linux. (Closed)

Created:
7 years, 10 months ago by Anders Johnsen

Modified:
7 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle single EPOLLHUP epoll events on Linux. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18878

Patch Set 2 : #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -21 lines)			Patch
	M	runtime/bin/eventhandler_linux.cc	View	1	3 chunks	+3 lines, -21 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12328052/diff/3001/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/12328052/diff/3001/runtime/bin/eventhandler_linux.cc#newcode269 runtime/bin/eventhandler_linux.cc:269: // If we have EPOLLIN and we have ...

7 years, 10 months ago (2013-02-22 11:41:19 UTC) #3

Anders Johnsen

Ty, landing. https://codereview.chromium.org/12328052/diff/3001/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/12328052/diff/3001/runtime/bin/eventhandler_linux.cc#newcode269 runtime/bin/eventhandler_linux.cc:269: // If we have EPOLLIN and we ...

7 years, 10 months ago (2013-02-22 11:42:19 UTC) #4

Anders Johnsen

7 years, 10 months ago (2013-02-22 11:42:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r18878 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12328052: Handle single EPOLLHUP epoll events on Linux. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages