Issue 12328035: Teach Selector.applies about mixins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12328035: Teach Selector.applies about mixins. (Closed)

Created:
7 years, 10 months ago by kasperl

Modified:
7 years, 10 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Teach Selector.applies about mixins. To determine whether or not an element applies to a selector we have to check if there is a subclass of the receiver type that mixes in the element instead of defining it. This checks must be done for both subclass and subtype checks. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18811

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -7 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View	1 chunk	+8 lines, -0 lines	1 comment	Download
A +	tests/language/mixin_override_regression_test.dart	View	1 chunk	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Beautiful! https://codereview.chromium.org/12328035/diff/1/sdk/lib/_internal/compiler/implementation/world.dart File sdk/lib/_internal/compiler/implementation/world.dart (right): https://codereview.chromium.org/12328035/diff/1/sdk/lib/_internal/compiler/implementation/world.dart#newcode136 sdk/lib/_internal/compiler/implementation/world.dart:136: return (uses != null) x ? y : ...

7 years, 10 months ago (2013-02-21 09:32:05 UTC) #2

kasperl

7 years, 10 months ago (2013-02-21 09:44:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r18811 (presubmit successful).

Expand Messages | Collapse Messages