Add path filter

Add path filter

BUG=
R=pquitslund@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9dd867c1fa646bd60cf2d86f8b9f95a63573613

[Cutch, 2015-07-17 16:57:12]

johnmccutchan@google.com changed reviewers:
+ brianwilkerson@google.com, pquitslund@google.com

[pquitslund, 2015-07-17 17:02:23]

Besides nits, LGTM.

Looking forward to seeing where this goes!

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/lib/source/pat...
File pkg/analyzer/lib/source/path_filter.dart (right):

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/lib/source/pat...
pkg/analyzer/lib/source/path_filter.dart:19: void setIgnorePatterns(List<String>
ignorePatterns) {
Style question: why not a setter here?

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/pubspec.yaml#n...
pkg/analyzer/pubspec.yaml:10: glob: ^1.0.5
I notice that the latest in third_party is 1.0.3...  Can we downgrade to that?

[Cutch, 2015-07-17 17:05:16]

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/lib/source/pat...
File pkg/analyzer/lib/source/path_filter.dart (right):

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/lib/source/pat...
pkg/analyzer/lib/source/path_filter.dart:19: void setIgnorePatterns(List<String>
ignorePatterns) {
On 2015/07/17 17:02:23, pquitslund wrote:
> Style question: why not a setter here?

Because the types don't match- List<String> vs List<Glob>

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/pubspec.yaml#n...
pkg/analyzer/pubspec.yaml:10: glob: ^1.0.5
On 2015/07/17 17:02:23, pquitslund wrote:
> I notice that the latest in third_party is 1.0.3...  Can we downgrade to that?

Done.

[pquitslund, 2015-07-17 17:06:26]

On 2015/07/17 17:05:16, Cutch wrote:
>
https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/lib/source/pat...
> File pkg/analyzer/lib/source/path_filter.dart (right):
> 
>
https://codereview.chromium.org/1232763004/diff/1/pkg/analyzer/lib/source/pat...
> pkg/analyzer/lib/source/path_filter.dart:19: void
setIgnorePatterns(List<String>
> ignorePatterns) {
> On 2015/07/17 17:02:23, pquitslund wrote:
> > Style question: why not a setter here?
> 
> Because the types don't match- List<String> vs List<Glob>

Erk.  Got it! :)

[Cutch, 2015-07-17 17:06:33]

Committed patchset #2 (id:20001) manually as
c9dd867c1fa646bd60cf2d86f8b9f95a63573613 (presubmit successful).

[Brian Wilkerson, 2015-07-17 17:29:06]

LGTM