Issue 12327010: Infer types of final fields.

Issue 12327010: Infer types of final fields. (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
karlklose, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Infer types of final fields. Committed: https://code.google.com/p/dart/source/detail?r=18825

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+363 lines, -154 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 2	5 chunks	+6 lines, -63 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1 2	1 chunk	+8 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View	1 2	1 chunk	+69 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 2	18 chunks	+259 lines, -87 lines	0 comments	Download
A	tests/language/field_override2_test.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler/implementation/ssa/types.dart File sdk/lib/_internal/compiler/implementation/ssa/types.dart (right): https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler/implementation/ssa/types.dart#newcode121 sdk/lib/_internal/compiler/implementation/ssa/types.dart:121: static HType mapBaseType(BaseType baseType, Compiler compiler) { Could these ...

7 years, 10 months ago (2013-02-21 08:32:38 UTC) #2

ngeoffray

Thanks Kasper. PTAL. https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler/implementation/ssa/types.dart File sdk/lib/_internal/compiler/implementation/ssa/types.dart (right): https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler/implementation/ssa/types.dart#newcode121 sdk/lib/_internal/compiler/implementation/ssa/types.dart:121: static HType mapBaseType(BaseType baseType, Compiler compiler) ...

7 years, 10 months ago (2013-02-21 11:35:16 UTC) #3

Thanks Kasper. PTAL.

https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/types.dart (right):

https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/types.dart:121: static HType
mapBaseType(BaseType baseType, Compiler compiler) {
On 2013/02/21 08:32:38, kasperl wrote:
> Could these be factory methods instead:
> 
>    HType.fromBaseType
>    HType.fromInferredType
> 
>    HType.inferredForElement
>    HType.inferredForNode
> 
> I think that would look a little bit cleaner.

Done.

https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:266:
compiler.enqueuer.resolution.seenClasses.forEach((ClassElement cls) {
On 2013/02/21 08:32:38, kasperl wrote:
> Why is this the seen classes and not the instantiated classes? Maybe extend
the
> comment to explain that.

Because we also need to analyze the final fields of super classes that are not
instantiated. Added the comment.

https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:492:
// Ff the field is being set at its declaration site, it is not
On 2013/02/21 08:32:38, kasperl wrote:
> Ff -> If / tracj -> tracked

Done.

https://codereview.chromium.org/12327010/diff/1001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:735:
if (!Elements.isUnresolved(element)
On 2013/02/21 08:32:38, kasperl wrote:
> There's some overlap between what's happening here and what's happening in
> run(). Can that be simplified?

Turns out it can be a lot simplified. Done.

ngeoffray

7 years, 10 months ago (2013-02-21 12:50:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r18825 (presubmit successful).

Expand Messages | Collapse Messages