Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232683003: Issue 23640. Implement 'analysis.getNavigation' request. (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -179 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +49 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 4 chunks +10 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 4 chunks +30 lines, -22 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 2 chunks +150 lines, -148 lines 0 comments Download
M pkg/analysis_server/test/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 1 comment Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +15 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
scheglov
5 years, 5 months ago (2015-07-10 22:13:59 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-10 22:29:38 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as d7c2f4550b64a460acc9785eba14a16a66a44707 (presubmit successful).
5 years, 5 months ago (2015-07-10 22:31:31 UTC) #3
Paul Berry
https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/test/analysis/test_all.dart File pkg/analysis_server/test/analysis/test_all.dart (right): https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/test/analysis/test_all.dart#newcode10 pkg/analysis_server/test/analysis/test_all.dart:10: import 'get_navigation_test.dart' as get_navigation_test; I don't see this file. ...
5 years, 5 months ago (2015-07-13 14:37:39 UTC) #5
devoncarew
https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode3193 pkg/analysis_server/tool/spec/spec_input.html:3193: An "analysis.getErrors" request specified a FilePath DBC: This looks ...
5 years, 5 months ago (2015-07-14 16:34:35 UTC) #7
scheglov
https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode3193 pkg/analysis_server/tool/spec/spec_input.html:3193: An "analysis.getErrors" request specified a FilePath On 2015/07/14 16:34:35, ...
5 years, 5 months ago (2015-07-21 15:05:52 UTC) #8
scheglov
5 years, 5 months ago (2015-07-21 15:05:53 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/1232683003/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3193: An "analysis.getErrors"
request specified a FilePath
On 2015/07/14 16:34:35, devoncarew wrote:
> DBC: This looks like a copy/paste issue - this should probably say
> "analysis.getNavigation".

Thanks!
https://codereview.chromium.org/1243073004

Powered by Google App Engine
This is Rietveld 408576698