Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 12326134: unittest fix: Get rid of the deprecation of IllegalJsRegexException's matcher. (Closed)

Created:
7 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 10 months ago
Reviewers:
gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

unittest fix: Get rid of the deprecation of IllegalJsRegexException's matcher. The underlying type has been deprecated for some time already, so I think we can safely get rid of this. Adding the @deprecated works, but adding the dependence on meta breaks some of our bots that don't use pub. Committed: https://code.google.com/p/dart/source/detail?r=19083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M pkg/unittest/lib/matcher.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/unittest/lib/src/core_matchers.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
7 years, 10 months ago (2013-02-26 21:32:20 UTC) #1
Siggi Cherem (dart-lang)
7 years, 10 months ago (2013-02-26 21:32:23 UTC) #2
gram
lgtm
7 years, 10 months ago (2013-02-26 21:33:36 UTC) #3
kevmoo-old
Please commit. I lack the bit. :-)
7 years, 10 months ago (2013-02-26 21:37:29 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r19083 (presubmit successful).
7 years, 10 months ago (2013-02-26 21:39:42 UTC) #5
Siggi Cherem (dart-lang)
7 years, 10 months ago (2013-02-26 21:40:37 UTC) #6
Message was sent while issue was closed.
thanks!

It's a shame, I'd have preferred to keep the @deprecated, but 'unittest' is used
heavily in the bots too, which is why we have this issue. 

For the other packages (e.g. logging), we should be ok.

Powered by Google App Engine
This is Rietveld 408576698