Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 12326132: Removing an unnecessary throw for JS interop. (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing an unnecessary throw for JS interop. Was hitting this debugging some code using JS interop, seems like a simple cleanup. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-02-26 20:58:58 UTC) #1
vsm
lgtm!
7 years, 9 months ago (2013-02-26 21:07:01 UTC) #2
blois
7 years, 9 months ago (2013-02-26 22:26:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698