Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1232613005: Allow super calls in mixins (for now behind a --supermixin flag). (Closed)

Created:
5 years, 5 months ago by regis
Modified:
5 years, 5 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow super calls in mixins (for now behind a --supermixin flag). As a consequence, allow a mixin application alias as a mixin, even if it does not extend Object. Add new tests. Fix an existing test. Update status files. Fixes #23771 R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/15de03e2d5e91a11a955ac25405ea00a1d825216

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -135 lines) Patch
M runtime/vm/class_finalizer.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 22 chunks +145 lines, -126 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/mixin_illegal_object_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download
A tests/language/mixin_super_bound2_test.dart View 1 1 chunk +65 lines, -0 lines 0 comments Download
A tests/language/mixin_super_bound_test.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download
A tests/language/mixin_super_test.dart View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
With my deepest sympathies.
5 years, 5 months ago (2015-07-17 00:13:48 UTC) #2
hausner
The sympathies should go to you, suffering the implementation of this insanity. LGTM, with a ...
5 years, 5 months ago (2015-07-17 16:55:22 UTC) #3
regis
Thanks! The runtime flag is part of the strategy to bring this feature online (see ...
5 years, 5 months ago (2015-07-17 18:29:51 UTC) #4
regis
5 years, 5 months ago (2015-07-17 18:32:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
15de03e2d5e91a11a955ac25405ea00a1d825216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698