Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12326071: Adding supported checks and annotations to Crypto API. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org, Mads Ager (google)
Visibility:
Public.

Description

Adding supported checks and annotations to Crypto API. BUG=8703 Committed: https://code.google.com/p/dart/source/detail?r=18985

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -44 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 18 chunks +25 lines, -19 lines 3 comments Download
M tests/html/crypto_test.dart View 1 chunk +33 lines, -21 lines 0 comments Download
M tests/html/html.status View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 10 months ago (2013-02-22 19:11:48 UTC) #1
Emily Fortuna
lgtm https://codereview.chromium.org/12326071/diff/2001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/12326071/diff/2001/sdk/lib/html/dartium/html_dartium.dart#oldcode15836 sdk/lib/html/dartium/html_dartium.dart:15836: - factory Int8Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length]) ...
7 years, 10 months ago (2013-02-22 20:25:49 UTC) #2
Mads Ager (google)
https://codereview.chromium.org/12326071/diff/2001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/12326071/diff/2001/sdk/lib/html/dartium/html_dartium.dart#oldcode15836 sdk/lib/html/dartium/html_dartium.dart:15836: - factory Int8Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length]) => ...
7 years, 10 months ago (2013-02-25 07:00:17 UTC) #3
Emily Fortuna
https://codereview.chromium.org/12326071/diff/2001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/12326071/diff/2001/sdk/lib/html/dartium/html_dartium.dart#oldcode15836 sdk/lib/html/dartium/html_dartium.dart:15836: - factory Int8Array.fromBuffer(ArrayBuffer buffer, [int byteOffset, int length]) => ...
7 years, 10 months ago (2013-02-25 17:00:15 UTC) #4
blois
7 years, 10 months ago (2013-02-25 17:39:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r18985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698