Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 12326041: Make an erroneous element when setting a final field. (Closed)

Created:
7 years, 10 months ago by ngeoffray
Modified:
7 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make an erroneous element when setting a final field. Committed: https://code.google.com/p/dart/source/detail?r=18819

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 10 months ago (2013-02-21 10:46:09 UTC) #1
karlklose
LGTM.
7 years, 10 months ago (2013-02-21 11:29:25 UTC) #2
ngeoffray
7 years, 10 months ago (2013-02-21 11:35:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698