Issue 12326012: Change the SSA construction pass to also construct def-use chains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12326012: Change the SSA construction pass to also construct def-use chains. (Closed)

Created:
7 years, 10 months ago by Kevin Millikin (Google)

Modified:
7 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the SSA construction pass to also construct def-use chains. Also modify constant propagation to preserve def-use chains. Fix a small bug in the def-use chain for definitions of inlined function return values. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=18813

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -174 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	6 chunks	+24 lines, -154 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	4 chunks	+28 lines, -13 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+1 line, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Everything is still low-level. I'll move the common patterns into SetInputAt, set_env, etc. or introduce ...

7 years, 10 months ago (2013-02-20 15:34:53 UTC) #1

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/12326012/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (left): https://codereview.chromium.org/12326012/diff/1/runtime/vm/intermediate_language.h#oldcode1113 runtime/vm/intermediate_language.h:1113: if (!Done()) Advance(); // Advance to the first ...

7 years, 10 months ago (2013-02-20 16:05:37 UTC) #2

Kevin Millikin (Google)

7 years, 10 months ago (2013-02-21 10:09:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18813 (presubmit successful).

Expand Messages | Collapse Messages