Issue 12326007: dart:io Directory.list: Fix use of snprintf return value to work with both C99, Windows, and pre-C9…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12326007: dart:io Directory.list: Fix use of snprintf return value to work with both C99, Windows, and pre-C9… (Closed)

Created:
7 years, 10 months ago by Bill Hesse

Modified:
7 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart:io Directory.list: Fix use of snprintf return value to work with both C99, Windows, and pre-C99 versions of snprintf. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18754

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -20 lines)			Patch
M	runtime/bin/directory_android.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	runtime/bin/directory_linux.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	runtime/bin/directory_macos.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

The pre-C99 version of snprintf isn't really out there, but its documentation is, and Windows ...

7 years, 10 months ago (2013-02-20 13:27:29 UTC) #1

Bill Hesse

7 years, 10 months ago (2013-02-20 13:34:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18754 (presubmit successful).