Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232463007: dart2js: Rename "current isolate" to "static state (holder)". (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 3 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Rename "current isolate" to "static state (holder)". R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/ec398a7385e634cd60b392d51a8650c140d4cb5f

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -65 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 3 chunks +11 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 6 chunks +8 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/registry.dart View 1 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 4 chunks +10 lines, -10 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/foreign_helper.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_mirrors.dart View 1 5 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 5 months ago (2015-07-10 13:37:27 UTC) #2
herhut
lgtm https://codereview.chromium.org/1232463007/diff/1/pkg/compiler/lib/src/js_backend/namer.dart File pkg/compiler/lib/src/js_backend/namer.dart (right): https://codereview.chromium.org/1232463007/diff/1/pkg/compiler/lib/src/js_backend/namer.dart#newcode1321 pkg/compiler/lib/src/js_backend/namer.dart:1321: bool _isPropertyOfStaticState(Element element) { this somehow reads strange... ...
5 years, 5 months ago (2015-07-10 13:56:21 UTC) #3
floitsch
Committed patchset #2 (id:20001) manually as ec398a7385e634cd60b392d51a8650c140d4cb5f (presubmit successful).
5 years, 5 months ago (2015-07-10 17:08:15 UTC) #4
floitsch
5 years, 3 months ago (2015-09-16 15:24:24 UTC) #5
Message was sent while issue was closed. 
Forgot to publish comments.

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_backend/namer.dart:1321: bool
_isPropertyOfStaticState(Element element) {
On 2015/07/10 13:56:20, herhut wrote:
> this somehow reads strange... Maybe 
> 
> _isPropertyOfStaticStateHolder
> 
> ?

Done.

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_emitter/program_builder/registry.dart (right):

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_emitter/program_builder/registry.dart:119: () => new
Holder(name, _holdersMap.length,
On 2015/07/10 13:56:20, herhut wrote:
> nit: use { } instead of =>?

Done.

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/builder.dart:4334: void
handleForeignSetStaticState(ast.Send node) {
On 2015/07/10 13:56:21, herhut wrote:
> While you're at it: This should probably be
> 
> handleForeignJsSetStaticState

Done.

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/builder.dart:4351: void
handleForeignJsStaticState(ast.Send node) {
On 2015/07/10 13:56:20, herhut wrote:
> I would prefer making this JsGetStaticState...

Done.

https://chromiumcodereview.appspot.com/1232463007/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/builder.dart:4374: } else if (name ==
'JS_STATIC_STATE') {
On 2015/07/10 13:56:20, herhut wrote:
> Maybe use JS_GET_STATIC_STATE?

Done.

https://chromiumcodereview.appspot.com/1232463007/diff/1/sdk/lib/_internal/js...
File sdk/lib/_internal/js_runtime/lib/isolate_helper.dart (left):

https://chromiumcodereview.appspot.com/1232463007/diff/1/sdk/lib/_internal/js...
sdk/lib/_internal/js_runtime/lib/isolate_helper.dart:34: JS_CURRENT_ISOLATE,
On 2015/07/10 13:56:21, herhut wrote:
> is this needed?

done.

Powered by Google App Engine
This is Rietveld 408576698